Repository navigation
feat(core): the new core is the bridges' only: apps no longer pick it through Rees46Config, Flutter and React Native start it with Rees46.initializeBridge - #242
Merged
Conversation
… through Rees46Config, Flutter and React Native start it with Rees46.initializeBridge Rees46Config has no coreV2: Rees46.initialize and Rees46.register ask for the legacy core, and source that passes coreV2 no longer compiles. A hidden constructor and copy with the old parameters keep apps built against 2.50 and 2.51 running; their coreV2 = true is ignored and logged as invalid_config (bridge_only). Rees46.initializeBridge(context, config, segment) is @BridgeAPI and hidden from Java: initialize on the new core. segment, the A/B group a bridge kept for the device, is taken while the device has no group of its own; a device that has one keeps it and a different segment is logged as invalid_config (segment_kept), a value other than A or B is refused with invalid_argument (invalid_segment). The process still runs one core, decided by the first initialize, register or initializeBridge, with core_flag_mismatch for an instance that asks for the other, now also when a live instance is asked again.
…traffic for the app; one that sends the advertising id on Android 13 and later, or talks http, declares them in its own manifest AD_ID came with reading the advertising id (5c67a22); play-services-ads-identifier 17.0.0 does not declare it, so without the app's own permission the legacy core's profile/set gets the zeroed id on Android 13 and later, and the new core reads it only with sendAdvertisingId. usesCleartextTraffic came into the SDK's manifest with 1.6.2 (the new stories, with video) without a stated reason; the SDK's own hosts are https, but an apiDomain with http:// and http images or videos of stories, popups and pushes need it. Documented on Rees46Config.apiDomain and Rees46Config.sendAdvertisingId.
…es is an invalid_config, as on iOS initializeBridge logs a segment other than A or B as invalid_config with the reason segment_invalid, beside segment_kept and device_id_kept, instead of invalid_argument (invalid_segment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps no longer pick the new core:
coreV2is gone fromRees46Config, andRees46.initializeandRees46.registerask for the legacy core. Source that passescoreV2stops compiling; apps built against 2.50–2.51 keep running through a hidden constructor andcopy, theircoreV2 = trueignored and logged (invalid_config,bridge_only).The Flutter and React Native bridges start their shops with
Rees46.initializeBridge(context, config, segment)(@BridgeApi, hidden from Java): the new core, and the A/B group the bridge kept for the device, taken while the device has none of its own (AorBonly). One core per process, as before.Manifest: the SDK no longer declares
AD_IDorusesCleartextTraffic; an app that sends the advertising id on Android 13+, or talkshttp://, declares them in its own manifest.